TST: Parametrize dtypes tests - test_common.py and test_concat.py #20340
Conversation
| object, 'float64', np.object_, np.dtype('object'), 'O', | ||
| np.float64, float, np.dtype('float64')]) | ||
| def test_pandas_dtype_valid(self, dtype): | ||
| assert com.pandas_dtype(dtype) == dtype |
There was a problem hiding this comment.
Not sure this test is actually necessary? Split this off from the test_invalid_dtype_error, as it appears to be testing valid instead of invalid dtypes. Previously this didn't have any type of assert statement; it just called pandas_dtype and the test passed if no error was raised.
There was a problem hiding this comment.
yeah this is ok, this is just testing that pandas_dtype doesn't raise on numpy dtypes
pandas/tests/dtypes/test_common.py
Outdated
| valid_list = [object, 'float64', np.object_, np.dtype('object'), 'O', | ||
| np.float64, float, np.dtype('float64')] | ||
| for dtype in valid_list: | ||
| @pytest.mark.parametrize('dtype', [pd.Timestamp, 'pd.Timestamp', list]) |
| object, 'float64', np.object_, np.dtype('object'), 'O', | ||
| np.float64, float, np.dtype('float64')]) | ||
| def test_pandas_dtype_valid(self, dtype): | ||
| assert com.pandas_dtype(dtype) == dtype |
There was a problem hiding this comment.
yeah this is ok, this is just testing that pandas_dtype doesn't raise on numpy dtypes
pandas/tests/dtypes/test_concat.py
Outdated
| Index, DatetimeIndex, PeriodIndex, TimedeltaIndex, Series, Period) | ||
|
|
||
|
|
||
| # test cases of the form (to_concat, expected) |
There was a problem hiding this comment.
can you make these fixtures? (or just put directly into the parameterize itself)
pandas/tests/dtypes/test_concat.py
Outdated
| assert result == set(expected) | ||
|
|
||
|
|
||
| # test cases of the form (to_concat, expected) |
jreback
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #20340 +/- ##
==========================================
- Coverage 91.76% 91.73% -0.03%
==========================================
Files 150 150
Lines 49151 49151
==========================================
- Hits 45102 45090 -12
- Misses 4049 4061 +12
Continue to review full report at Codecov.
|
|
made the requested changes |
|
thanks @jschendel |
Parametrized some straightforward dtypes related tests.
Relatively minor changes to
test_common.py:forloopsMade larger changes to
test_concat.py:check_concatvalidation function since it's only called once nowforloop previously in thecheck_concatvalidation functionimport pandas as pdin favor of directly importing the necessary classes