-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: update the pandas.Series.str.split docstring #20307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update the pandas.Series.str.split docstring #20307
Conversation
@mananpal1997 Thanks! Additional comment: on line 1121, the indentation should be the same as the line above, can you fix that as well? (cannot comment on that line :-)) @WillAyd did you have a proposal to write the Returns section more clear? |
9184934
to
52fe248
Compare
Nice job @mananpal1997. I suggest the Return type line just say |
pandas/core/strings.py
Outdated
split : Series/Index or DataFrame/MultiIndex of objects | ||
Type matches caller unless ``expand=True`` (return type is DataFrame or | ||
MultiIndex) | ||
split : Series, Index, DataFrame or MultiIndex of objects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are only returning one item you don't need to list the variable name, so get rid of "split : ". Also chop " of objects" off the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WillAyd I was trying to resolve for coverage and I think I messed up with PR. Does everything look good to you? 😅
b57f570
to
c9bf3e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #20307 +/- ##
=======================================
Coverage 91.7% 91.7%
=======================================
Files 150 150
Lines 49165 49165
=======================================
Hits 45087 45087
Misses 4078 4078
Continue to review full report at Codecov.
|
c9bf3e8
to
1a2efb0
Compare
1a2efb0
to
7169830
Compare
Added a see also. Thanks @mananpal1997. |
Following up from discussion on #20282
scripts/validate_docstrings.py pandas.Series.str.split docstring
git diff upstream/master -u -- "*.py" | flake8 --diff
python doc/make.py --single pandas.Series.str.split docstring
@jorisvandenbossche @WillAyd