-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: update the DataFrame.at[] docstring #20290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update the DataFrame.at[] docstring #20290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor edits otherwise looks good
pandas/core/indexing.py
Outdated
|
||
See Also | ||
-------- | ||
DataFrame.iat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the See Also section the format should be item : description
so move to the description up to the same line and just break where length exceeds 75 characters
pandas/core/indexing.py
Outdated
>>> df.at[4, 'B'] | ||
10 | ||
|
||
Get value within a series |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize Series
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comments of @WillAyd, looks good!
Thank you for the comments! I believe I have addressed them all, but please let me know if there's anything else that can be improved. |
Codecov Report
@@ Coverage Diff @@
## master #20290 +/- ##
==========================================
+ Coverage 91.7% 91.73% +0.02%
==========================================
Files 150 150
Lines 49168 49168
==========================================
+ Hits 45090 45102 +12
+ Misses 4078 4066 -12
Continue to review full report at Codecov.
|
Thanks @akosel! |
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>
git diff upstream/master -u -- "*.py" | flake8 --diff
python doc/make.py --single <your-function-or-method>
Please include the output of the validation script below between the "```" ticks:
If the validation script still gives errors, but you think there is a good reason
to deviate in this case (and there are certainly such cases), please state this
explicitly.