DOC: update the pandas.DataFrame.clip_lower docstring #20289
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5718,30 +5718,34 @@ def clip_lower(self, threshold, axis=None, inplace=False): | |
| """ | ||
| Return copy of the input with values below given value(s) trimmed. | ||
|
|
||
| Elements below the `threshold` will be changed to `threshold`. | ||
|
There was a problem hiding this comment. "changed to match the |
||
|
|
||
| Parameters | ||
| ---------- | ||
| threshold : float or array-like | ||
| Lower value(s) to which the input value(s) will be trimmed. | ||
| axis : {0 or ‘index’, 1 or ‘columns’, None}, default None | ||
|
There was a problem hiding this comment. Sorry I think this was a copy/paste issue but you should be fine with normal single quotes around the values |
||
| Align object with threshold along the given axis. | ||
| inplace : boolean, default False | ||
| Whether to perform the operation in place on the data. | ||
|
|
||
| .. versionadded:: 0.21.0 | ||
|
|
||
|
There was a problem hiding this comment. Sorry if I forgot some discussion about it, but don't we want a There was a problem hiding this comment. Yes good spot we definitely still want this - @adatasetaday can you add back in? I know we had some back and forth about |
||
| See Also | ||
| -------- | ||
| DataFrame.clip : Trim values at input threshold(s). | ||
|
There was a problem hiding this comment. Some suggested better wording:
There was a problem hiding this comment. Done, but changed the order to "more related" to "less related". |
||
| DataFrame.clip_upper : Return copy of input with values above given | ||
| value(s) trimmed. | ||
| Series.clip : Trim values at input threshold(s). | ||
| Series.clip_lower : Return copy of the input with values below given | ||
| value(s) trimmed. | ||
| Series.clip_upper : Return copy of input with values above given | ||
| value(s) trimmed. | ||
|
|
||
| Returns | ||
| ------- | ||
| Series or DataFrame | ||
| Same type as caller. | ||
|
There was a problem hiding this comment. For this method may be it's a bit obvious, but for consistency I'd say in the description what this method returns (e.g. Original data with values trimmed). The note about the time is all right (not sure if other methods have it as part of the type or the description). There was a problem hiding this comment. Would any of these work? Series or DataFrame (same type as caller) Series or DataFrame There was a problem hiding this comment. They look great. If you want to take a look at the latest merged pull requests, I think this happens in few, and may be there is a way more standard than another. If you don't find any, from my side you can choose whatever you want. There was a problem hiding this comment. Based on what I see in the code, this seems to be the most common format type of caller I was thinking that there would be some value in creating PRs for standarizing these kind of things. For example, do one that fixes the axis parameters in ALL methods to match the format agreed in the discussions in this sprint. Another one could be done to make sure there is no period after the versionadded (which a lot of them have it, probably due to the validating script complaining if it was not there). Would this be a good idea? Who should I contact if I want to take care of some of these? There was a problem hiding this comment. Feel free to do it. I'd probably wait until most of the PRs from the sprint are closed, to avoid conflicts. And more than contacting someone, you can create an issue (or one per change) with what you're planning to do, you can get some discussion and feedback before doing all the work. |
||
|
|
||
| Examples | ||
|
There was a problem hiding this comment. Nice job here - I think the examples are very clear |
||
| -------- | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use "caller" instead of "input". FWIW I guess it's not technically true that it returns a copy of the caller because
inplacewould modify directly. Any idea on how to make this statement more accurate?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something along the line of
Return a copy of the caller (or the caller itself if inplace == True) with values below given
thresholdtrimmed.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm well I don't think you need to get in the discussion of return values since that's documented later in the docstring. First line is supposed to be very simple so I would mirror what's there for
clipand say something likeTrim the caller's values below a given thresholdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Since Series.clip_lower uses the same docstring (the function is defined in generic.py) I thought that I should change the "See Also" description for Series.clip_lower to be the same. But when I tested the generation of the HTML I realized that if we use the "See Also" as it is right now, for Series.clip_lower we will not have a reference to DataFrame.clip_lower and it will have a reference to itself.
Does this make sense? Is there an elegant way to solve it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that makes sense. Typically in this case you could use the
@Substitutiondecorator - you'll see some other functions using in that same module.That said, since your method is currently just inherited by
SeriesandDataFrameand not necessarily overriden, I don't think there's a good way without overriding those implementation (if even just to call super) to implement Substitution. Unless you can think of a better way, I'd suggest you remove theclip_lowerreference in See Also and open up a separate issue to try and make substitution workThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I can also only think of overriding in order for it to work. But is it worth the effort just to make the "See Also" complete? Would a reference to just clip_lower (without DataFrame. or Series. prefixes) be a good enough option?
I'll sleep through it to see if I can think of something better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say just remove but if you come up with a better idea then by all means