Skip to content

CI: use dateutil-master in testing #20288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 11, 2018

closes #18332

@jreback jreback added the CI Continuous Integration label Mar 11, 2018
@jreback jreback added this to the 0.23.0 milestone Mar 11, 2018
@jreback
Copy link
Contributor Author

jreback commented Mar 11, 2018

cc @pganssle

(pandas) bash-3.2$ pytest pandas/tests/tslibs/test_parsing.py --tb=short
=============================================================================================================================== test session starts ===============================================================================================================================
platform darwin -- Python 3.6.3, pytest-3.3.0, py-1.5.2, pluggy-0.6.0
rootdir: /Users/jreback/pandas, inifile: setup.cfg
plugins: xdist-1.20.1, forked-0.2, cov-2.5.1, hypothesis-3.38.5
collected 42 items                                                                                                                                                                                                                                                                

pandas/tests/tslibs/test_parsing.py ......ssssssssssssssFFsssFFF.ssssssFFFFFF.                                                                                                                                                                                              [100%]

==================================================================================================================================== FAILURES =====================================================================================================================================
__________________________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_with_dayfirst_gt_261[True] __________________________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:146: in test_guess_datetime_format_with_dayfirst_gt_261
    assert result is None
E   AssertionError: assert '%d/%m/%Y' is None
_________________________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_with_dayfirst_gt_261[False] __________________________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:146: in test_guess_datetime_format_with_dayfirst_gt_261
    assert result is None
E   AssertionError: assert '%m/%d/%Y' is None
_______________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_with_locale_specific_formats_gt_261[30/Dec/2011] _______________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:172: in test_guess_datetime_format_with_locale_specific_formats_gt_261
    assert result is None
E   AssertionError: assert '%d/%b/%Y' is None
____________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_with_locale_specific_formats_gt_261[30/December/2011] _____________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:172: in test_guess_datetime_format_with_locale_specific_formats_gt_261
    assert result is None
E   AssertionError: assert '%d/%B/%Y' is None
__________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_with_locale_specific_formats_gt_261[30/Dec/2011 00:00:00] ___________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:172: in test_guess_datetime_format_with_locale_specific_formats_gt_261
    assert result is None
E   AssertionError: assert '%d/%b/%Y %H:%M:%S' is None
__________________________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_nopadding_gt_261[2011-1-1] __________________________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:220: in test_guess_datetime_format_nopadding_gt_261
    assert result is None
E   AssertionError: assert '%Y-%m-%d' is None
_________________________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_nopadding_gt_261[30-1-2011] __________________________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:220: in test_guess_datetime_format_nopadding_gt_261
    assert result is None
E   AssertionError: assert '%d-%m-%Y' is None
__________________________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_nopadding_gt_261[1/1/2011] __________________________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:220: in test_guess_datetime_format_nopadding_gt_261
    assert result is None
E   AssertionError: assert '%m/%d/%Y' is None
_____________________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_nopadding_gt_261[2011-1-1 00:00:00] ______________________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:220: in test_guess_datetime_format_nopadding_gt_261
    assert result is None
E   AssertionError: assert '%Y-%m-%d %H:%M:%S' is None
_______________________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_nopadding_gt_261[2011-1-1 0:0:0] _______________________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:220: in test_guess_datetime_format_nopadding_gt_261
    assert result is None
E   AssertionError: assert '%Y-%m-%d %H:%M:%S' is None
______________________________________________________________________________________________ TestGuessDatetimeFormat.test_guess_datetime_format_nopadding_gt_261[2011-1-3T00:00:0] ______________________________________________________________________________________________
pandas/tests/tslibs/test_parsing.py:220: in test_guess_datetime_format_nopadding_gt_261
    assert result is None
E   AssertionError: assert '%Y-%m-%dT%H:%M:%S' is None
================================================================================================================= 11 failed, 8 passed, 23 skipped in 0.36 seconds =================================================================================================================

@pganssle
Copy link
Contributor

@jreback A lot of these seem to be "breaking" in that you expect to be unable to infer the format, but now you are able to. Am I understanding this correctly?

@pganssle
Copy link
Contributor

pganssle commented Mar 11, 2018

CC @jbrockmendel

May be related to a bunch of the stuff you fixed in this dateutil release.

@jreback
Copy link
Contributor Author

jreback commented Mar 11, 2018

yeah we prob just need to adjust the tests.

@codecov
Copy link

codecov bot commented Mar 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0ae89b0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #20288   +/-   ##
=========================================
  Coverage          ?   91.73%           
=========================================
  Files             ?      150           
  Lines             ?    49171           
  Branches          ?        0           
=========================================
  Hits              ?    45105           
  Misses            ?     4066           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.11% <100%> (?)
#single 41.87% <100%> (?)
Impacted Files Coverage Δ
pandas/util/_test_decorators.py 92.2% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae89b0...fc388ad. Read the comment docs.

@jreback jreback merged commit 0815c43 into pandas-dev:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: use dateutil master
2 participants