-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: update the pandas.DataFrame.clip docstring #20212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2448809
docstring for clip
Dpananos aaeb2dc
clip docstring
Dpananos 62afcab
Edit Docstring
Dpananos 33af7ce
docstrings clip
Dpananos cb8d7ab
clip docstring
Dpananos e062a88
clip docstring
Dpananos 87f8b5b
clip docstring
Dpananos 1371a23
docstring for pandas.DataFrame.clip
Dpananos 674ffb6
clip docstring
Dpananos 495847d
docstring clip
Dpananos 89a7690
docstring clip
Dpananos 131c052
clip docstring
Dpananos 089e882
docstring clip
Dpananos 1089460
clip docstring
Dpananos 60c34db
docstring clip
Dpananos 9aeda8e
clip docstring
Dpananos 75eecd1
clip docstring
Dpananos 504389f
clip docstring
Dpananos 694f9fb
clip docstring
Dpananos af991cc
clip docstring
Dpananos 141e8c9
clip docstring
Dpananos 383c56d
docstring clip
Dpananos 3f1c785
docstring clip
Dpananos 90d8268
docstring clip
Dpananos bd26d0f
docstring clip
Dpananos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would just mention Series.clip here (not upper/lower)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you find
clip_upper
andclip_lower
related? I suggested them, but actually I was wondering if I was missing something, or if it was being considered deprecating them. It seems to me thatclip(upper=X)
could be used forclip_upper
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to deprecate lower/upper but that’s not the reason
when showing a DataFrame method only like to show 1 Series method and and any related DataFrame method
just a preference to not have too many things in See Also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
But if I'm not wrong, the title is misleading but this docstring is for the Series.clip method too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh ok in that case this is ok