-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Improve the docstring of Series.take #20179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Improve the docstring of Series.take #20179
Conversation
Signed-off-by: Gianpaolo Macario <[email protected]>
pandas/core/generic.py
Outdated
is_copy : bool, default True | ||
Whether to return a copy of the original object or not. | ||
kwargs : xxx, default xxx | ||
TODO MUST ADD A REASONABLE DESCRIPTION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional keyword arguments to ``:meth:pandas.compat.numpy.function.validate_take
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in later commit
pandas/core/generic.py
Outdated
See Also | ||
-------- | ||
numpy.ndarray.take : TODO | ||
numpy.take : TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take elements from an array along an axis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in later commit
pandas/core/generic.py
Outdated
|
||
See Also | ||
-------- | ||
numpy.ndarray.take : TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return an array formed from the elements at given indices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in later commit
Address review comments in pull/20179 Signed-off-by: Gianpaolo Macario <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #20179 +/- ##
=========================================
Coverage ? 91.76%
=========================================
Files ? 150
Lines ? 49151
Branches ? 0
=========================================
Hits ? 45102
Misses ? 4049
Partials ? 0
Continue to review full report at Codecov.
|
Hello @kynan I believe I have addressed all your review feedbacks with my recent commits. Thanks! |
[ci skip]
[ci skip]
[ci skip]
Thanks @gmacario. |
See pandas-dev/pandas#20179 Signed-off-by: Gianpaolo Macario <[email protected]>
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>
git diff upstream/master -u -- "*.py" | flake8 --diff
python doc/make.py --single <your-function-or-method>
Please include the output of the validation script below between the "```" ticks:
If the validation script still gives errors, but you think there is a good reason
to deviate in this case (and there are certainly such cases), please state this
explicitly.
Signed-off-by: Gianpaolo Macario [email protected]