Skip to content

COMPAT: Matplotlib 2.2 compatability #20079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 13, 2018
Merged

COMPAT: Matplotlib 2.2 compatability #20079

merged 6 commits into from
Mar 13, 2018

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Mar 9, 2018 •
edited by jreback
Loading

Summary of changes

  • clean up version detection in compat
  • Update timedelta tick formatting tests. Matplotlib fixed tick formatting of timedeltas so they're consistent with non-timedelta formatting.

closes #20031

@TomAugspurger TomAugspurger added Visualization plotting Dependencies Required and optional dependencies labels Mar 9, 2018
@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Mar 9, 2018
@pep8speaks
Copy link

pep8speaks commented Mar 9, 2018 •
edited
Loading

Hello @TomAugspurger! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on March 12, 2018 at 15:27 Hours UTC

@codecov
Copy link

codecov bot commented Mar 9, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@bfe6ebc). Click here to learn what that means.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #20079   +/-   ##
=========================================
  Coverage          ?   91.73%           
=========================================
  Files             ?      150           
  Lines             ?    49139           
  Branches          ?        0           
=========================================
  Hits              ?    45078           
  Misses            ?     4061           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.11% <90%> (?)
#single 41.9% <75%> (?)
Impacted Files Coverage Δ
pandas/plotting/_compat.py 90.9% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe6ebc...ef0d6ad. Read the comment docs.

TomAugspurger
TomAugspurger commented Mar 9, 2018
View reviewed changes
doc/source/whatsnew/v0.23.0.txt Outdated
@@ -343,6 +343,7 @@ Other Enhancements
- :meth:`Timestamp.day_name` and :meth:`DatetimeIndex.day_name` are now available to return day names with a specified locale (:issue:`12806`)
- :meth:`DataFrame.to_sql` now performs a multivalue insert if the underlying connection supports itk rather than inserting row by row.
``SQLAlchemy`` dialects supporting multivalue inserts include: ``mysql``, ``postgresql``, ``sqlite`` and any dialect with ``supports_multivalues_insert``. (:issue:`14315`, :issue:`8953`)
- Compatability with matplotlib 2.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll think I'll remove this just before merging. Other than table, which is broken for py27, there weren't any comparability issues.

jreback
jreback reviewed Mar 10, 2018
View reviewed changes
pandas/tests/plotting/test_datetimelike.py
@@ -1382,10 +1382,6 @@ def test_format_timedelta_ticks_narrow(self):
for l, l_expected in zip(labels, expected_labels):
assert l.get_text() == l_expected

@td.xfail_if_mpl_2_2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we originally had the mac skips on here (e.g. before 2.2). not really sure if they are still relevant though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm testing on a mac, so hopefully we're OK.

@TomAugspurger TomAugspurger changed the title [WIP] Matplotlib 2.2 compatability COMPAT: Matplotlib 2.2 compatability Mar 12, 2018
@TomAugspurger TomAugspurger mentioned this pull request Mar 12, 2018
Closed
@TomAugspurger
Copy link
Contributor Author

This should be good to go.

@jreback jreback merged commit b1c113f into pandas-dev:master Mar 13, 2018
@jreback
Copy link
Contributor

jreback commented Mar 13, 2018

thanks!

@TomAugspurger TomAugspurger deleted the mpl-2.2 branch March 13, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies Visualization plotting
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

Compatibility with matplotlib 2.2
3 participants
@TomAugspurger @pep8speaks @jreback