-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Adding sample datasets to be used in the documentation #19933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I thought we had an issue about this already, IIRC @mrocklin either made it or commented (was for a slightly different purpose though). |
We already have lots of data constructors in |
I don't know if there is an older issue, but this is related to what is recently discussed in #19710 as @datapythonista linked to.
Indeed, I don't think the ones in util.testing are suitable for this, as the exact purpose of those are to be 'nicer' relate-able small dataframes. |
Any more thoughts on this? Knowing which data to use for the examples in the docstrings is the main blocker for the sprint. Any feedback on how you think we can improve this first draft is highly appreciated. Thanks! |
This needs to be imported in some |
import pandas | ||
|
||
|
||
def _countries_with_penguins(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need to be de-privatized (no leading _)
columns = ('Code', 'Name', 'Capital', 'Continent', | ||
'Penguin species', 'Avg. temperature') | ||
data = [ | ||
('AO', 'Angola', 'Luanda', 'AF', 1, 21.55), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need tests
For what has been discussed in #19710, seems like it probably makes more sense to simply have some ideas on data to be used, but use custom datasets as simple and illustrative as possible depending on each case. So, closing this. |
git diff upstream/master -u -- "*.py" | flake8 --diff