-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fixed issue with leftover test.json file #19879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/source/whatsnew/v0.23.0.txt
Outdated
df.to_json('test.json', orient='table') | ||
new_df = pd.read_json('test.json', orient='table') | ||
|
||
test_json_buf = io.StringIO() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, a user reading this doesn't have to care about any of the stuff with the IO buffer. They only care about writing and reading the dataframe.
I think it's best to leave the df.to_json
and new_df =
as it was previosly.
Then we can add a new ipython
block afterwards to remove the file.
.. ipython:: python
:suppress:
import os
os.remove('test.json')
Codecov Report
@@ Coverage Diff @@
## master #19879 +/- ##
=========================================
Coverage ? 91.65%
=========================================
Files ? 150
Lines ? 48915
Branches ? 0
=========================================
Hits ? 44835
Misses ? 4080
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls change to using @TomAugspurger soln
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff