Use pandas_datetimestruct instead of date_info #19874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 23, 2018
pandas/_libs/tslibs/period.pyx
Outdated
|
|
||
|
|
||
| cdef inline int max_value(int left, int right) nogil: | ||
| # Cython doesn't support "max(...)" in nogil blocks |
There was a problem hiding this comment.
this is defined in multiple places in the code add already
Codecov Report
@@ Coverage Diff @@
## master #19874 +/- ##
=========================================
Coverage ? 91.67%
=========================================
Files ? 150
Lines ? 48946
Branches ? 0
=========================================
Hits ? 44870
Misses ? 4076
Partials ? 0
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 24, 2018
pandas/_libs/tslibs/period.pyx
Outdated
|
|
||
| if ordinal == iNaT: | ||
| return iNaT | ||
|
|
||
| if end: | ||
| retval = asfreq(ordinal, freq1, freq2, END) |
There was a problem hiding this comment.
use ? : or jut make the if/else include the function (simpler)
pandas/_libs/tslibs/period.pyx
Outdated
|
|
||
| if retval == INT32_MIN: | ||
| raise ValueError('Frequency conversion failed') | ||
|
|
||
| return retval | ||
|
|
||
|
|
||
| cdef void get_asfreq_info(int from_freq, int to_freq, | ||
| char relation, asfreq_info *af_info) nogil: | ||
| cdef: |
jreback
reviewed
Feb 25, 2018
|
|
||
| npy_int64 get_daytime_conversion_factor(int from_index, int to_index); | ||
| int max_value(int a, int b); |
There was a problem hiding this comment.
really? ok, need to fix this up later. too much duplicated floating around, but I guess when this is fully cythonized can remove this.
jreback
approved these changes
Feb 25, 2018
|
thanks. |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes test file name from previous pass