Skip to content

DOC: Updated links to 2 tutorials in tutorials.rst #19857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2018
Merged

DOC: Updated links to 2 tutorials in tutorials.rst #19857

merged 2 commits into from
Feb 24, 2018

Conversation

tommyod
Copy link
Contributor

@tommyod tommyod commented Feb 23, 2018

Two of the links to the pandas-cookbook did not work for version v0.2 of the documents. Now all links work. Where a version v0.2 exists, it links to that version. In the remaining two cases, it now links to version v0.1 instead of raising the 404: Page not found error.

@jorisvandenbossche
Copy link
Member

I would rather update the actual links and keep linking to the newer version, as those chapters still exist (the name was a bit changed): http://nbviewer.jupyter.org/github/jvns/pandas-cookbook/tree/master/cookbook/

@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #19857 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19857   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         150      150           
  Lines       48946    48946           
=======================================
  Hits        44858    44858           
  Misses       4088     4088
Flag Coverage Δ
#multiple 90.02% <ø> (ø) ⬆️
#single 41.81% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce77b79...3f09bc3. Read the comment docs.

@tommyod
Copy link
Contributor Author

tommyod commented Feb 24, 2018

I agree @jorisvandenbossche. Thanks for reviewing! I have updated this PR:

  • Every link is to v2.0 now.
  • Another chapter has been written (Chapter 9), I have added it.

And I believe this PR is good to go then.

@jreback jreback added this to the 0.23.0 milestone Feb 24, 2018
@jreback jreback merged commit e52a059 into pandas-dev:master Feb 24, 2018
@jreback
Copy link
Contributor

jreback commented Feb 24, 2018

thanks!

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants