Skip to content

Separate TimedeltaIndex mul/div tests #19848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Conversation

jbrockmendel
Copy link
Member

Collect DTI/TDI/PI indexing tests ~symmetrically.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Timedelta Timedelta data type labels Feb 23, 2018
@gfyoung
Copy link
Member

gfyoung commented Feb 23, 2018

Collect DTI/TDI/PI indexing tests ~symmetrically.

@jbrockmendel : Can you clarify what you mean by that?

@jreback jreback added this to the 0.23.0 milestone Feb 23, 2018
@jreback jreback merged commit ce77b79 into pandas-dev:master Feb 23, 2018
@jreback
Copy link
Contributor

jreback commented Feb 23, 2018

thanks. pls parameterize / de-dupe on next passes

@jbrockmendel
Copy link
Member Author

Can you clarify what you mean by that?

@gfyoung Each of datetimes/timedeltas/periods have a test_indexing.py file, but they aren't (weren't) consistent about what methods get tested in that file. This aligned the organization between these three files.

@jbrockmendel jbrockmendel deleted the tdtests branch February 23, 2018 15:23
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants