Skip to content

BUG: GH19458 fixes precision issue in TimeDelta.total_seconds() #19783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2018

Conversation

mikekutzma
Copy link
Contributor

@pep8speaks
Copy link

pep8speaks commented Feb 20, 2018

Hello @mikekutzma! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 20, 2018 at 11:19 Hours UTC

@codecov
Copy link

codecov bot commented Feb 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1cf0c3a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19783   +/-   ##
=========================================
  Coverage          ?   91.61%           
=========================================
  Files             ?      150           
  Lines             ?    48887           
  Branches          ?        0           
=========================================
  Hits              ?    44786           
  Misses            ?     4101           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.98% <ø> (?)
#single 41.8% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf0c3a...3e9cb9d. Read the comment docs.

@jreback jreback added the Timedelta Timedelta data type label Feb 20, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 20, 2018
@jreback jreback added the Bug label Feb 20, 2018
@jreback jreback merged commit 1de47fb into pandas-dev:master Feb 20, 2018
@jreback
Copy link
Contributor

jreback commented Feb 20, 2018

thanks!

@mikekutzma mikekutzma deleted the GH19458 branch February 20, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precision error when using Timedelta.total_seconds method
3 participants