TST: add test for numpy ops, esp. nanmin/max bug for np<1.13 #19753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
np_nanmin_nanmax
branch
from
359f1ec to
be0b2a4
Compare
jreback
requested changes
Feb 18, 2018
pandas/tests/test_nanops.py
Outdated
| @@ -15,6 +16,7 @@ | |||
| import pandas.util._test_decorators as td | |||
|
|
|||
| use_bn = nanops._USE_BOTTLENECK | |||
| np_version113 = LooseVersion(np.__version__) >= LooseVersion('1.13') | |||
There was a problem hiding this comment.
import from pandas
we already define this
pandas/tests/test_nanops.py
Outdated
| (np.nanmax, False, 4), | ||
| ]) | ||
| def test_numpy_ops(numpy_op, passes_all_numpy_version, expected): | ||
| # GH8383 |
There was a problem hiding this comment.
you can just make 2 tests
1 for numpy >= 1.13 and 1 for < 1.13 which assert those functions which exist there
jreback
added
Numeric Operations
topper-123
force-pushed
the
np_nanmin_nanmax
branch
from
be0b2a4 to
07b2995
Compare
|
Comments addressed. Not sure if I understood your second, but please look at changed test functions. |
jreback
approved these changes
Feb 18, 2018
|
lgtm ping on green |
Codecov Report
@@ Coverage Diff @@
## master #19753 +/- ##
==========================================
- Coverage 91.6% 91.6% -0.01%
==========================================
Files 150 150
Lines 48864 48864
==========================================
- Hits 44763 44761 -2
- Misses 4101 4103 +2
Continue to review full report at Codecov.
|
|
all green. |
|
thanks @topper-123 |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThe bug in #8383 concerns np.nanmin and np.nanmax only, don't know if I'm testing too much.