Skip to content

split off scalar tests to submodules #19752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 19, 2018
Merged

split off scalar tests to submodules #19752

merged 5 commits into from
Feb 19, 2018

Conversation

jbrockmendel
Copy link
Member

Spun off from #19738, implements test_arithmetic for timedeltas, moves and organizes tests without changing anything in the non-test code.

A handful of xfail tests are implemented (these are fixed in #19378)

jreback
jreback requested changes Feb 18, 2018
View reviewed changes
pandas/tests/scalar/test_timedelta.py Outdated
@@ -105,15 +105,6 @@ def test_timedelta_ops_scalar(self):
result = base - offset
assert result == expected_sub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to the sub module as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will get moved (and parametrized) in an upcoming pass. For right now this PR is intended to be a minimal set that will allow for #19378 to go through.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to move it now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but just this one...

@jreback jreback added Testing pandas testing functions or related to the test suite Timedelta Timedelta data type labels Feb 18, 2018
@codecov
Copy link

codecov bot commented Feb 18, 2018 •
edited
Loading

Codecov Report

Merging #19752 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19752      +/-   ##
==========================================
+ Coverage    91.6%    91.6%   +<.01%     
==========================================
  Files         150      150              
  Lines       48864    48864              
==========================================
+ Hits        44761    44762       +1     
+ Misses       4103     4102       -1
Flag Coverage Δ
#multiple 89.98% <ø> (ø) ⬆️
#single 41.77% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/core/ops.py 96.62% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f0c63...6d45594. Read the comment docs.

This was referenced Feb 19, 2018
Merged
Closed
Closed
@jreback jreback added this to the 0.23.0 milestone Feb 19, 2018
@jreback
Copy link
Contributor

jreback commented Feb 19, 2018

moved the rest of the scalar files. ping on green.

@jreback jreback changed the title Spinoff from #19378 split off scalar tests to submodules Feb 19, 2018
@jreback jreback merged commit 718d067 into pandas-dev:master Feb 19, 2018
@jreback
Copy link
Contributor

jreback commented Feb 19, 2018

@jbrockmendel you will need to rebase anything that involves scalar tests

@jbrockmendel jbrockmendel mentioned this pull request Feb 19, 2018
Merged
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
@jbrockmendel
split off scalar tests to submodules (pandas-dev#19752)
81e2f76
@jbrockmendel jbrockmendel deleted the td-tests branch June 22, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Timedelta Timedelta data type
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback