FIX: const-correctness in numpy helpers #19749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python 3.7 the return type of PyUnicode_AsUTF8 changed from (char *) to (const char *). PyUnicode_FromString also takes (const char *) as input, also be explicit about that. https://bugs.python.org/issue28769 commit 2a404b63d48d73bbaa007d89efb7a01048475acd in cpython
jreback
added
the
Compat
|
thanks @tacaswell haven't touched 3.7 yet!!! |
|
ping on green. |
|
@tcaswell do you have a 3.7 going on CI? |
|
my day-to-day enviroment at home is cpython master + master branch of most of the scipy stack 😈 . |
Codecov Report
@@ Coverage Diff @@
## master #19749 +/- ##
==========================================
- Coverage 91.6% 91.6% -0.01%
==========================================
Files 150 150
Lines 48864 48864
==========================================
- Hits 44763 44761 -2
- Misses 4101 4103 +2
Continue to review full report at Codecov.
|
|
thanks @tacaswell happy to have these |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
In python 3.7 the return type of PyUnicode_AsUTF8 changed from (char *) to (const char *). PyUnicode_FromString also takes (const char *) as input, also be explicit about that. https://bugs.python.org/issue28769 commit 2a404b63d48d73bbaa007d89efb7a01048475acd in cpython
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.7 the return type of PyUnicode_AsUTF8 changed
from (char *) to (const char *).
PyUnicode_FromString also takes (const char *) as input, also be
explicit about that.
https://bugs.python.org/issue28769
commit 2a404b63d48d73bbaa007d89efb7a01048475acd in cpython
git diff upstream/master -u -- "*.py" | flake8 --diff