GroupBy Rank SegFault Fix - astype instead of view #19701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you merge in master? The timeouts will hopefully be fixed... |
|
adding @jreback for merge |
chris-b1
reviewed
Feb 14, 2018
pandas/_libs/groupby_helper.pxi.in
Outdated
| @@ -531,7 +531,7 @@ def group_rank_{{name}}(ndarray[float64_t, ndim=2] out, | |||
| # each label corresponds to a different group value, | |||
| # the mask helps you differentiate missing values before | |||
| # performing sort on the actual values | |||
| _as = np.lexsort(order).view(dtype=np.int64) | |||
| _as = np.lexsort(order).astype(np.int64) | |||
There was a problem hiding this comment.
add copy=False which will elide the copy on a 64 bit platform.
WillAyd
force-pushed
the
rank-segflt-fix
branch
from
e038d58 to
6f18d31
Compare
|
sure can merge on green. |
|
thanks again @WillAyd |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
* Use astype instead of view for lexsort upcasting * Added copy=False to astype in group_rank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #19679 and #19481