-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH-19629: Adding numpy nansun/nanmean, etc etc to _cython_table #19670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
AaronCritchley
wants to merge
20
commits into
pandas-dev:master
from
AaronCritchley:ENH-19629-np-nan-funcs-to-cython-map
Closed
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0d39286
Adding numpy nansun/nanmean, etc etc to _cython_table
AaronCritchley 47936c7
Adding in tests, implementing suggested whatsnew entry
AaronCritchley d2671e6
Fixing flake8 errors
AaronCritchley 29ccb18
PR comments, support for np.nanprod
AaronCritchley b702747
Merge branch 'master' of git://github.com/pandas-dev/pandas into ENH-…
AaronCritchley 130f767
skipping if nanprod not implemented
AaronCritchley 0e4657a
Checking np version explicitly
AaronCritchley 64c0d93
Using pytest params
AaronCritchley fdaeaf9
Updating for np 1.12
AaronCritchley cabb307
Merge branch 'master' of git://github.com/pandas-dev/pandas into ENH-…
AaronCritchley 0c5a2ae
Fixing bad indentation
AaronCritchley 7157161
Moving compat test functions inline to prevent build time issue
AaronCritchley 93e332d
Merge branch 'master' of git://github.com/pandas-dev/pandas into ENH-…
AaronCritchley 8c2a5dd
Making use of fixtures for series and df generation
AaronCritchley 5326d56
Fixing silly formatting, removing external function to compare
AaronCritchley bdd2917
Merge branch 'master' into ENH-19629-np-nan-funcs-to-cython-map
AaronCritchley 528e12b
Restoring whatsnew to normal after messy merge
AaronCritchley e88ac10
More whatsnew cleanup
AaronCritchley 40e4dff
Merge branch 'master' of git://github.com/pandas-dev/pandas into ENH-…
AaronCritchley c9ddaff
Merge branch 'ENH-19629-np-nan-funcs-to-cython-map' of github.com:Aar…
AaronCritchley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be a single function that is parameterized over all of the methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will do this soon - could you help with why the build is failing?
From looking at CircleCI it seems like it's not recognizing that np.nanprod is valid, do I need to remove the nanprod case for compat or something? Sorry if I'm being dense here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might need to skip for older versions of numpy
not sure when certain ones were added