TST: split tests for windows to sub-modules #19667

giba0 · 2018-02-12T20:41:23Z

Splitting the test_window.py file into the test_rolling.py files, test_expanding.py
and test_ewma.py

closes TST: split tests for windows to sub-modules #19228
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

This reverts commit bf59983.

…ing.py, and test_ewma.py

…st_window.py

…window.py file

…w.py file

…pandas-dev#19228

…19228'

…quet-documentation-pandas-dev#19662'

codecov · 2018-02-12T23:22:36Z

Codecov Report

Merging #19667 into master will decrease coverage by 0.21%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #19667      +/-   ##
==========================================
- Coverage   91.82%    91.6%   -0.22%     
==========================================
  Files         152      150       -2     
  Lines       49248    48864     -384     
==========================================
- Hits        45222    44763     -459     
- Misses       4026     4101      +75

Flag	Coverage Δ
#multiple	`89.98% <0%> (-0.24%)`	⬇️
#single	`41.75% <0%> (-0.15%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/frame.py	`97.22% <0%> (+0.04%)`	⬆️
pandas/tseries/plotting.py	`0% <0%> (-100%)`	⬇️
pandas/core/dtypes/base.py	`47.61% <0%> (-44.28%)`	⬇️
pandas/plotting/_compat.py	`62% <0%> (-28.91%)`	⬇️
pandas/core/arrays/base.py	`60% <0%> (-24.15%)`	⬇️
pandas/io/s3.py	`72.72% <0%> (-13.64%)`	⬇️
pandas/core/missing.py	`85.9% <0%> (-5.75%)`	⬇️
pandas/plotting/_timeseries.py	`60.82% <0%> (-4.49%)`	⬇️
pandas/core/reshape/tile.py	`90.25% <0%> (-3.12%)`	⬇️
pandas/io/html.py	`85.98% <0%> (-2.81%)`	⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfce2b...8ee74d9. Read the comment docs.

This reverts commit bf59983.

…ing.py, and test_ewma.py

…st_window.py

…window.py file

…w.py file

This reverts commit bf59983.

This reverts commit 2a49a9a.

jreback · 2018-02-13T11:37:16Z

looks like you picked up some other commits (in the parquet module), can you merge master (or revert these if you did those).

jreback · 2018-02-13T11:38:48Z

want to parameterize some of these, but can wait for another pass for that.

giba0 · 2018-02-13T11:44:13Z

@jreback I'm a little confused, because I sent two PR's, but I did not understand why it was all together! Can you help me?

jreback · 2018-02-13T11:48:13Z

for a new PR checkout from master like this
git checkout -b new_branch origin/master

for now you need to rebase on master and remove those commits - like

git rebase -i origin/master

and delete the uneeded commits

giba0 · 2018-02-13T19:00:17Z

@jreback I did the suggested fix, could you check it now?

jreback · 2018-02-16T18:33:05Z

someting when really wrong. you need to git merge upstream/master (if upstream is the pandas-dev repo, sometimes also called origin).

only your changes should be here.

…for-windows-to-sub-modules-pandas-dev#19228

…19228'

giba0 · 2018-02-17T19:22:39Z

Now I think it worked! Can you check, please?

jreback · 2018-02-18T16:52:13Z

you have a ton of other changes in here. you need to have just the 4 files (the original and the split off ones)

jreback · 2018-02-18T16:57:49Z

pandas/tests/windows/test_rolling.py

+N, K = 100, 10
+
+
+def assert_equal(left, right):


don't repeat things. 2 ways to solve this, have a common.py and import, or you can use fixtures to do this properly.

In this case I just need to insert @pytest.fixture?

jreback · 2018-02-18T16:58:21Z

pandas/tests/windows/test_expanding.py

+                with pytest.raises(ValueError):
+                    c(min_periods=1, center=w)
+
+    def test_numpy_compat(self):


parameterize this

Can you hlep me? Here I need use a decorator @pytest.mark.parametrize?

jreback · 2018-02-18T16:58:43Z

pandas/tests/windows/test_expanding.py

+    def test_constructor(self):
+        # GH 12669
+
+        for o in [self.series, self.frame]:


create a fixture for series and frame (in conftest.py)

jreback · 2018-02-18T16:59:08Z

pandas/tests/windows/test_ewma.py

+        tm.assert_frame_equal(left, right)
+
+
+class Base(object):


jreback · 2018-02-24T15:29:53Z

can you update

jreback · 2018-03-16T22:14:33Z

can you rebase / update

jreback · 2018-07-08T16:08:12Z

can you rebase

jreback · 2018-07-08T16:08:25Z

closing as stale

giba0 added 15 commits February 12, 2018 00:02

documentação

bf59983

Revert "documentação"

2a49a9a

This reverts commit bf59983.

Merge branch 'master' into upstream/master

a6a5e96

Merge remote-tracking branch 'origin/master'

f235163

Merge branch 'master' into upstream/master

55b2661

Creating the window folder and the files test_rolling.py, test_expand…

1785d61

…ing.py, and test_ewma.py

Inclusion of tests for the rolling functions according to the file te…

b9c121d

…st_window.py

Inclusion of tests for the expanding functions according to the test_…

018685b

…window.py file

Inclusion of tests for the ewma functions according to the test_windo…

3cef534

…w.py file

Correcting file formatting.

9cb7a4f

Merge branch 'master' of https://github.com/pandas-dev/pandas

9a4469e

Merge branch 'master' into TST--split-tests-for-windows-to-sub-modules-…

52db43a

…pandas-dev#19228

Merge branch 'TST--split-tests-for-windows-to-sub-modules-pandas-dev#…

375c68d

…19228'

Ambiguity correction in documentation on pandas.DataFrame.to_parquet

8414a1f

Merge branch 'DOCS---Ambiguous-description-in-pandas.DataFrame.to_par…

229c9c1

…quet-documentation-pandas-dev#19662'

giba0 added 10 commits February 12, 2018 22:56

documentação

2962a8f

Revert "documentação"

4544afa

This reverts commit bf59983.

Creating the window folder and the files test_rolling.py, test_expand…

ccf473f

…ing.py, and test_ewma.py

Inclusion of tests for the rolling functions according to the file te…

95d9d0e

…st_window.py

Inclusion of tests for the expanding functions according to the test_…

e65af3b

…window.py file

Inclusion of tests for the ewma functions according to the test_windo…

a3abbb9

…w.py file

Correcting file formatting.

af463bb

Ambiguity correction in documentation on pandas.DataFrame.to_parquet

6f74164

Revert "documentação"

5ca693a

This reverts commit bf59983.

Revert "Revert "documentação""

ac0f751

This reverts commit 2a49a9a.

jreback added Testing pandas testing functions or related to the test suite Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Feb 13, 2018

giba0 added 2 commits February 13, 2018 16:50

Merge branch 'split-tests'

a8c0b01

Merge branch 'master' into split-tests

9b99bf8

giba0 added 2 commits February 13, 2018 20:00

Merge remote-tracking branch 'origin/master'

5fb9885

Merge remote-tracking branch 'upstream/master'

9778aa9

giba0 added 3 commits February 17, 2018 16:56

Merge remote-tracking branch 'upstream/master' into TST--split-tests-…

39e9292

…for-windows-to-sub-modules-pandas-dev#19228

Merge remote-tracking branch 'origin/master'

02de0d7

Merge branch 'TST--split-tests-for-windows-to-sub-modules-pandas-dev#…

05b00be

…19228'

Merge branch 'master' into PR_TOOL_MERGE_PR_19667

7343a88

jreback requested changes Feb 18, 2018

View reviewed changes

Merge branch 'master' of https://github.com/pandas-dev/pandas

8ee74d9

jreback closed this Jul 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: split tests for windows to sub-modules #19667

TST: split tests for windows to sub-modules #19667

giba0 commented Feb 12, 2018

codecov bot commented Feb 12, 2018 •

edited

Loading

jreback commented Feb 13, 2018

jreback commented Feb 13, 2018

giba0 commented Feb 13, 2018

jreback commented Feb 13, 2018

giba0 commented Feb 13, 2018

jreback commented Feb 16, 2018

giba0 commented Feb 17, 2018 •

edited

Loading

jreback commented Feb 18, 2018

jreback Feb 18, 2018

giba0 Feb 24, 2018

jreback Feb 18, 2018

giba0 Feb 24, 2018

jreback Feb 18, 2018

jreback Feb 18, 2018

jreback commented Feb 24, 2018

jreback commented Mar 16, 2018

jreback commented Jul 8, 2018

jreback commented Jul 8, 2018

TST: split tests for windows to sub-modules #19667

TST: split tests for windows to sub-modules #19667

Conversation

giba0 commented Feb 12, 2018

codecov bot commented Feb 12, 2018 • edited Loading

Codecov Report

jreback commented Feb 13, 2018

jreback commented Feb 13, 2018

giba0 commented Feb 13, 2018

jreback commented Feb 13, 2018

giba0 commented Feb 13, 2018

jreback commented Feb 16, 2018

giba0 commented Feb 17, 2018 • edited Loading

jreback commented Feb 18, 2018

jreback Feb 18, 2018

Choose a reason for hiding this comment

giba0 Feb 24, 2018

Choose a reason for hiding this comment

jreback Feb 18, 2018

Choose a reason for hiding this comment

giba0 Feb 24, 2018

Choose a reason for hiding this comment

jreback Feb 18, 2018

Choose a reason for hiding this comment

jreback Feb 18, 2018

Choose a reason for hiding this comment

jreback commented Feb 24, 2018

jreback commented Mar 16, 2018

jreback commented Jul 8, 2018

jreback commented Jul 8, 2018

codecov bot commented Feb 12, 2018 •

edited

Loading

giba0 commented Feb 17, 2018 •

edited

Loading