tests for tslibs.conversion and tslibs.timezones #19642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 10, 2018
| compare_utc_to_local(tz_didx, utc_didx) | ||
| # local tz to UTC can be differ in hourly (or higher) freqs because | ||
| # of DST | ||
| compare_local_to_utc(tz_didx, utc_didx) |
jreback
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #19642 +/- ##
==========================================
+ Coverage 91.58% 91.59% +<.01%
==========================================
Files 150 150
Lines 48806 48806
==========================================
+ Hits 44701 44703 +2
+ Misses 4105 4103 -2
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 11, 2018
| compare_utc_to_local(tz_didx, utc_didx) | ||
| # local tz to UTC can be differ in hourly (or higher) freqs because | ||
| # of DST | ||
| compare_local_to_utc(tz_didx, utc_didx) |
jreback
requested changes
Feb 12, 2018
| compare_utc_to_local(tz_didx, utc_didx) | ||
| compare_local_to_utc(tz_didx, utc_didx) | ||
|
|
||
| def test_tz_convert_empty(self): |
There was a problem hiding this comment.
let's parameterize empty/nat and make a single test
| from pandas import Timestamp | ||
|
|
||
|
|
||
| class TestTimeZoneCacheKey(object): |
There was a problem hiding this comment.
no reason to make this part of a class
| tz_didx = date_range('2014-03-01', '2015-01-10', freq='H', tz=tz) | ||
| utc_didx = date_range('2014-03-01', '2015-01-10', freq='H') | ||
| compare_utc_to_local(tz_didx, utc_didx) | ||
| # local tz to UTC can be differ in hourly (or higher) freqs because |
jreback
reviewed
Feb 14, 2018
|
|
||
| from datetime import datetime | ||
|
|
||
| import pandas.util.testing as tm | ||
| from pandas.core.indexes.datetimes import date_range | ||
| from pandas._libs import tslib |
There was a problem hiding this comment.
Not much. I'll try to kill it off after clearing out the current PR backlog.
jreback
approved these changes
Feb 14, 2018
|
thanks |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last one.