fix overflows in Timestamp.tz_localize near boundaries #19626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19626 +/- ##
==========================================
- Coverage 91.62% 91.61% -0.01%
==========================================
Files 150 150
Lines 48798 48807 +9
==========================================
+ Hits 44709 44716 +7
- Misses 4089 4091 +2
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 10, 2018
pandas/_libs/tslibs/conversion.pyx
Outdated
| @@ -490,12 +493,37 @@ cdef _TSObject convert_str_to_tsobject(object ts, object tz, object unit, | |||
| return convert_to_tsobject(ts, tz, unit, dayfirst, yearfirst) | |||
|
|
|||
|
|
|||
| cdef inline _check_silent_overflows(_TSObject obj): | |||
There was a problem hiding this comment.
de-privatize. by definition not public if its not in the .pxd
pandas/_libs/tslibs/conversion.pyx
Outdated
| # ---------------------------------------------------------------------- | ||
| # Localization | ||
|
|
||
| cdef inline void _localize_tso(_TSObject obj, object tz): | ||
| cdef inline void _localize_tso(_TSObject obj, tzinfo tz): |
| @@ -15,12 +15,29 @@ | |||
| import pandas.util._test_decorators as td | |||
|
|
|||
| from pandas import Timestamp, NaT | |||
| from pandas._libs.tslib import OutOfBoundsDatetime | |||
jreback
added
Error Reporting
jreback
requested changes
Feb 10, 2018
pandas/_libs/tslibs/conversion.pyx
Outdated
| if obj.value != NPY_NAT: | ||
| # check_silent_overflows needs to run after localize_tso | ||
| check_dts_bounds(&obj.dts) | ||
| check_silent_overflows(obj) |
pandas/_libs/tslibs/conversion.pyx
Outdated
| @@ -490,12 +493,37 @@ cdef _TSObject convert_str_to_tsobject(object ts, object tz, object unit, | |||
| return convert_to_tsobject(ts, tz, unit, dayfirst, yearfirst) | |||
|
|
|||
|
|
|||
| cdef inline check_silent_overflows(_TSObject obj): | |||
There was a problem hiding this comment.
rename, add doc-string (just convert your comment)
pandas/_libs/tslibs/conversion.pyx
Outdated
|
|
||
| Returns | ||
| ------- | ||
| (void) |
jreback
approved these changes
Feb 10, 2018
|
lgtm. ping ongreen. |
|
Ping |
|
thanks |
|
some warnings as a result of this change |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
|
when you have a chance can you look at the warnings above: #19626 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flesh out docstring for localize_tsobject, add slightly stronger typing.
Closes #12677