ERR: raise KeyError on invalid column name in aggregate #19566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Error Reporting
|
cc @discort |
discort
reviewed
Feb 7, 2018
doc/source/whatsnew/v0.23.0.txt
Outdated
| @@ -647,7 +647,7 @@ Groupby/Resample/Rolling | |||
| - Bug in :func:`DataFrame.groupby` where aggregation by ``first``/``last``/``min``/``max`` was causing timestamps to lose precision (:issue:`19526`) | |||
| - Bug in :func:`DataFrame.transform` where particular aggregation functions were being incorrectly cast to match the dtype(s) of the grouped data (:issue:`19200`) | |||
| - Bug in :func:`DataFrame.groupby` passing the `on=` kwarg, and subsequently using ``.apply()`` (:issue:`17813`) | |||
| - Bug in :func:`DataFrame.resample().aggregate` not raising a `ValueError` when aggregating a non-existent column (:issue:`16766`) | |||
| - Bug in :func:`DataFrame.resample().aggregate` not raising a ``ValueError`` when aggregating a non-existent column (:issue:`16766`, :issue:`19566`) | |||
There was a problem hiding this comment.
Didn't you forget to replace ValueError by KeyError at this line?
There was a problem hiding this comment.
shoot yeah must not have committed
thanks
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #19552
xref https://github.com/pandas-dev/pandas/pull/19552/files#r166587045