-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: improve get_loc on unsorted, non-unique indexes #19539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a383697
to
cf36911
Compare
Codecov Report
@@ Coverage Diff @@
## master #19539 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 153 153
Lines 49481 49481
=======================================
Hits 45430 45430
Misses 4051 4051
Continue to review full report at Codecov.
|
seems to be failing 2.7 on windows and a gazillion warnings
|
also can you see if this closes other issues as well (a couple of refernces in OP) |
cf36911
to
da08bb8
Compare
@jreback : fixed (wasn't that hard!), ping. (I guess it shouldn't harm to include in 0.23.0) |
@toobaz lgtm. can you just update the asv's as the top with latest code |
Done. |
thanks @toobaz |
git diff upstream/master -u -- "*.py" | flake8 --diff
asv run: