Skip to content

PKG: Exclude data test files. #19535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jun 26, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
4d77cd8
PKG: Exclude data test files.
TomAugspurger Feb 3, 2018
270e442
Stuff
TomAugspurger Feb 6, 2018
26e9b4b
Merge remote-tracking branch 'upstream/master' into package-size
TomAugspurger Feb 22, 2018
1804bcc
Refactor data path handling
TomAugspurger Feb 25, 2018
7022152
More fixtures
TomAugspurger Feb 25, 2018
080f000
Merge remote-tracking branch 'upstream/master' into package-size
TomAugspurger Mar 26, 2018
151ffda
Updated html
TomAugspurger Mar 26, 2018
d9d6570
Remove os.path.joins
TomAugspurger Mar 26, 2018
5849591
More modules
TomAugspurger Mar 27, 2018
31fb0b6
Some more
TomAugspurger Mar 27, 2018
9193f15
Merge remote-tracking branch 'upstream/master' into package-size
TomAugspurger Mar 27, 2018
e897f11
Updated packers
TomAugspurger Mar 27, 2018
9cf30fd
Pickle
TomAugspurger Mar 27, 2018
95cde7a
Linting
TomAugspurger Mar 27, 2018
10ddddc
Autouse stata
TomAugspurger Mar 27, 2018
e1ea208
Remove filename
TomAugspurger Mar 27, 2018
8616878
Autouse in merge_asof
TomAugspurger Mar 27, 2018
77bf77c
Cleanup plotting
TomAugspurger Mar 27, 2018
156e14b
CLN: Simplify fspath
TomAugspurger Mar 27, 2018
f3f3662
Refactor sql tests
TomAugspurger Mar 27, 2018
2cd9706
Merge remote-tracking branch 'upstream/master' into package-size
TomAugspurger Mar 27, 2018
aac3606
Fixed docstrings
TomAugspurger Mar 27, 2018
762a2d1
Moved
TomAugspurger Mar 27, 2018
7c44b77
Use fixture for iris plotting
TomAugspurger Mar 28, 2018
ad09951
Abs path for file test
TomAugspurger Mar 28, 2018
6f02d6b
Removed stdout capture from sql tests
TomAugspurger Mar 29, 2018
489f540
Merge remote-tracking branch 'origin/master' into package-size
TomAugspurger May 12, 2018
8b42d1c
Merge remote-tracking branch 'upstream/master' into package-size
TomAugspurger May 12, 2018
ee4fefd
Merge remote-tracking branch 'upstream/master' into package-size
TomAugspurger Jun 12, 2018
bac438c
Cleanup Manifest
TomAugspurger Jun 12, 2018
84ccdbf
fixed test test
TomAugspurger Jun 12, 2018
c4802db
Merge remote-tracking branch 'upstream/master' into package-size
TomAugspurger Jun 20, 2018
7fd7660
Fixed windows
TomAugspurger Jun 20, 2018
c187f8b
whatsnew
TomAugspurger Jun 20, 2018
632a61d
Clarify note [ci skip]
TomAugspurger Jun 20, 2018
b5b70c7
TST: refactored html tests
TomAugspurger Jun 21, 2018
9954bba
Remove auto-generated html fixtures
TomAugspurger Jun 22, 2018
c771885
linting
TomAugspurger Jun 22, 2018
dd75270
Removed test test file
TomAugspurger Jun 26, 2018
dbe0c57
Merge remote-tracking branch 'upstream/master' into package-size
TomAugspurger Jun 26, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/source/whatsnew/v0.23.2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ Documentation Changes
-
-

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a ref here as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note: IMO it is not needed to always ask this of contributors, as this ref is only needed when we actually want to make an explicit link to it from within the rst files (and chances are quite high we will never do this). The ref can always be added at the moment one adds a link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but in general its a good practice

Build Changes
-------------

- The source and binary distributions no longer include test files, resulting in smaller download sizes. Tests relying on these files will be skipped when using ``pandas.test()``. (:issue:`19320`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test files -> "test data files" or "data files for testing"


.. _whatsnew_0232.bug_fixes:

Bug Fixes
Expand Down
8 changes: 8 additions & 0 deletions pandas/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,14 @@ def iris(datapath):
return pandas.read_csv(datapath('data', 'iris.csv'))


@pytest.fixture(params=['nlargest', 'nsmallest'])
def nselect_method(request):
"""
Fixture for trying all nselect methods
"""
return request.param


@pytest.fixture(params=[None, np.nan, pd.NaT, float('nan'), np.float('NaN')])
def nulls_fixture(request):
"""
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/util/test_testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,6 @@ def test_datapath_missing(datapath, request):
with pytest.raises(ValueError):
datapath('not_a_file')

result = datapath('data/iris.csv')
result = datapath('data', 'iris.csv')
expected = os.path.join('pandas', 'tests', 'data', 'iris.csv')
assert result == expected