Skip to content

ops cleanup, named functions instead of lambdas #19515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2018

Conversation

jbrockmendel
Copy link
Member

Lots more ops work in the pipeline, this is just the easy bits that don't need new tests.

Having reversed funcs that can be referenced will make things easier in some of the Index classmethods.

@pep8speaks
Copy link

pep8speaks commented Feb 2, 2018

Hello @jbrockmendel! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 03, 2018 at 00:27 Hours UTC

@codecov
Copy link

codecov bot commented Feb 3, 2018

Codecov Report

Merging #19515 into master will decrease coverage by 0.1%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19515      +/-   ##
==========================================
- Coverage   91.69%   91.59%   -0.11%     
==========================================
  Files         148      150       +2     
  Lines       48561    48705     +144     
==========================================
+ Hits        44530    44612      +82     
- Misses       4031     4093      +62
Flag Coverage Δ
#multiple 89.96% <84%> (-0.1%) ⬇️
#single 41.75% <64%> (+0.03%) ⬆️
Impacted Files Coverage Δ
pandas/core/ops.py 95.22% <84%> (-0.52%) ⬇️
pandas/errors/__init__.py 92.3% <0%> (-7.7%) ⬇️
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️
pandas/core/arrays/categorical.py 94.74% <0%> (-1.04%) ⬇️
pandas/core/internals.py 95.05% <0%> (-0.42%) ⬇️
pandas/core/dtypes/dtypes.py 96.08% <0%> (-0.04%) ⬇️
pandas/core/arrays/__init__.py 100% <0%> (ø) ⬆️
pandas/core/arrays/base.py 56.66% <0%> (ø)
pandas/core/dtypes/base.py 47.61% <0%> (ø)
pandas/core/dtypes/common.py 95.37% <0%> (+0.05%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69cd5fb...e39ad01. Read the comment docs.

@jreback jreback added the Clean label Feb 4, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 4, 2018
@jreback jreback merged commit 56dbaae into pandas-dev:master Feb 4, 2018
@jreback
Copy link
Contributor

jreback commented Feb 4, 2018

thanks!

@jbrockmendel jbrockmendel deleted the ops_kwargs8 branch February 4, 2018 16:39
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants