DOC: minor groupby and resampler improvements #19514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19514 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 150 150
Lines 48714 48714
=======================================
Hits 44633 44633
Misses 4081 4081
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 4, 2018
doc/source/groupby.rst
Outdated
| @@ -1230,7 +1230,7 @@ code more readable. First we set the data: | |||
| import numpy as np | |||
| n = 1000 | |||
| df = pd.DataFrame({'Store': np.random.choice(['Store_1', 'Store_2'], n), | |||
| 'Product': np.random.choice(['Product_1', 'Product_2', 'Product_3'], n), | |||
| 'Product': np.random.choice(['Product_1','Product_2'], n), | |||
There was a problem hiding this comment.
can you put back the formatting. this is not lint compatbile
topper-123
force-pushed
the
clean_pipe_docs
branch
from
3a3a324 to
49714e8
Compare
|
All green. |
jorisvandenbossche
approved these changes
Feb 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffSome minor improvements to groupby and resampler. In particular:
groupby.pipe