Skip to content

split Timestamp tests off of #19504 #19511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2018
Merged

Conversation

jbrockmendel
Copy link
Member

There is de-duplication/parametrization etc to be done, but that should wait until the tests are collected because we'll have to re-do it then anyway.

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #19511 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19511      +/-   ##
==========================================
- Coverage   91.69%   91.67%   -0.03%     
==========================================
  Files         148      148              
  Lines       48561    48561              
==========================================
- Hits        44530    44518      -12     
- Misses       4031     4043      +12
Flag Coverage Δ
#multiple 90.03% <ø> (-0.03%) ⬇️
#single 41.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69cd5fb...161bd4b. Read the comment docs.

@jreback jreback added Testing pandas testing functions or related to the test suite Timezones Timezone data dtype labels Feb 4, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 4, 2018
@jreback
Copy link
Contributor

jreback commented Feb 4, 2018

this is fine, assuming you are going to completely destruct pandas/tests/tseries/test_timezones and put the tests in the appropriate places ?

@jreback jreback merged commit a44f1c1 into pandas-dev:master Feb 4, 2018
@jreback
Copy link
Contributor

jreback commented Feb 4, 2018

thanks!

@jbrockmendel jbrockmendel deleted the tztests4 branch February 4, 2018 16:40
@jbrockmendel
Copy link
Member Author

this is fine, assuming you are going to completely destruct pandas/tests/tseries/test_timezones and put the tests in the appropriate places ?

Most of it will go into Timestamp/DatetimeIndex/...-specific modules. There are some pieces that are more directly testing tslibs.timezones/tslibs.conversions, which can either stay in tests.tseries or go into a new tests.tslibs.

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants