separate DTI, Timestamp, Series, DataFrame, tslibs timezones tests #19504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
split |
|
better in pieces |
jreback
pushed a commit
that referenced
this pull request
Feb 4, 2018
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phew, this is a big one. test_timezones has a ton of redundant tests scattered about, many of which are in classes that cause them to incorrectly get run twice. This separates them by what class they are testing, with (for now at least) to_datetime and date_range getting their own categories.
There are a ton of DTI.tz_localize tests. This splits some of them up and tries to name them helpfully, but there is going to have to be another pass. I also expect that there are tests for DTI.tz_localize and DTI.tz_convert elsewhere in tests.indexes.datetimes that we will want to centralize. Ditto for test_timestamps.
Finally this separates out a small subset of tests that are specifically testing tslibs (not including Timestamp)
LMK if this should be split into smaller pieces for easier review.
git diff upstream/master -u -- "*.py" | flake8 --diff