Skip to content

implement timedeltas.test_scalar_compat #19503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

jbrockmendel
Copy link
Member

Centralize and split redundant TDI.shift tests in test_arith

@pep8speaks
Copy link

pep8speaks commented Feb 2, 2018

Hello @jbrockmendel! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 02, 2018 at 02:48 Hours UTC

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #19503 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19503      +/-   ##
==========================================
+ Coverage   91.67%    91.7%   +0.02%     
==========================================
  Files         148      148              
  Lines       48553    48553              
==========================================
+ Hits        44513    44525      +12     
+ Misses       4040     4028      -12
Flag Coverage Δ
#multiple 90.06% <ø> (+0.02%) ⬆️
#single 41.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ba063...6ec7e5e. Read the comment docs.

@jreback jreback added this to the 0.23.0 milestone Feb 2, 2018
@jreback jreback added Testing pandas testing functions or related to the test suite Timedelta Timedelta data type labels Feb 2, 2018
@jreback jreback merged commit f6b260b into pandas-dev:master Feb 2, 2018
@jreback
Copy link
Contributor

jreback commented Feb 2, 2018

thanks!

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
@jbrockmendel jbrockmendel deleted the tztests branch June 22, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants