Skip to content

Centralize Arithmetic Tests #19471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 31, 2018
Merged

Centralize Arithmetic Tests #19471

merged 7 commits into from
Jan 31, 2018

Conversation

jbrockmendel
Copy link
Member

Lots of tests in tests.series.test_operators and tests.frame.test_operators that need to be split up, parametrized, and moved to the appropriate test_arithmetic module+class. This handles the most obvious cases.

@codecov
Copy link

codecov bot commented Jan 31, 2018

Codecov Report

Merging #19471 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19471      +/-   ##
==========================================
+ Coverage    91.6%   91.62%   +0.02%     
==========================================
  Files         150      150              
  Lines       48724    48724              
==========================================
+ Hits        44632    44644      +12     
+ Misses       4092     4080      -12
Flag Coverage Δ
#multiple 89.99% <ø> (+0.02%) ⬆️
#single 41.74% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37d867...76d32df. Read the comment docs.

@jreback jreback added Testing pandas testing functions or related to the test suite Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations labels Jan 31, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 31, 2018
@jreback jreback merged commit d9daec8 into pandas-dev:master Jan 31, 2018
@jreback
Copy link
Contributor

jreback commented Jan 31, 2018

thanks!

@jbrockmendel jbrockmendel deleted the ops_tests branch February 11, 2018 22:00
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants