BUG: Fixed accessor for Categorical[Datetime] #19469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Datetime
Codecov Report
@@ Coverage Diff @@
## master #19469 +/- ##
==========================================
- Coverage 91.62% 91.59% -0.03%
==========================================
Files 150 150
Lines 48724 48728 +4
==========================================
- Hits 44642 44633 -9
- Misses 4082 4095 +13
Continue to review full report at Codecov.
|
|
Thanks, LGTM |
jreback
reviewed
Jan 30, 2018
| def test_dt_namespace_accessor_categorical(self): | ||
| # GH 19468 | ||
| dti = pd.DatetimeIndex(['20171111', '20181212']).repeat(2) | ||
| s = pd.Series(pd.Categorical(dti), name='foo') |
There was a problem hiding this comment.
can you not use pd. here where we don't elsewhere
|
lgtm. merge on green. |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
* BUG: Fixed accessor for Categorical[Datetime] * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19468
No release note, since this was only a regression on master.
cc @jschendel.