DOC: Spellcheck of categorical.rst and visualization.rst #19428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 29, 2018
doc/source/categorical.rst
Outdated
|
|
||
| .. ipython:: python | ||
|
|
||
| df = pd.DataFrame({"A":["a","b","c","a"]}) | ||
| df["B"] = df["A"].astype('category') | ||
| df | ||
|
|
||
| By using some special functions: | ||
| By using special functions, such as :func:`~pandas.cut` (:ref:`docs here | ||
| <reshaping.tile.cut>`): |
There was a problem hiding this comment.
can you expand the ref for the cut section in the docs
Codecov Report
@@ Coverage Diff @@
## master #19428 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 150 150
Lines 48728 48728
=======================================
Hits 44645 44645
Misses 4083 4083
Continue to review full report at Codecov.
|
jreback
approved these changes
Jan 31, 2018
|
thanks @tommyod . these are very welcome PR's. If possible, can you put a PR per file (unless very little changes). Just a bit easier to review. thanks! keep em coming |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to the documentation, specifically
categorical.rstandvisualization.rst:``around Series, DataFrame.Comments very welcome.