Remove src/numpy.pxd #19418
Merged
Remove src/numpy.pxd #19418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19418 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 150 150
Lines 48724 48724
=======================================
Hits 44658 44658
Misses 4066 4066
Continue to review full report at Codecov.
|
jreback
reviewed
Jan 27, 2018
| cnp.import_array() | ||
|
|
||
| cdef extern from "numpy/arrayobject.h": | ||
| # These can be cimported directly from numpy in cython>=0.27.3 |
There was a problem hiding this comment.
should prob put array dtype introspection in a single place and expose viais_timedelta64_array (new) somewhere maybe util.pxd
|
thanks |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existence of the src/numpy.pxd file causes ambiguity as to where cimports are coming from. src/numpy.pxd? cython's numpy/init.pxd? What about the np.get_include() uses in setup.py?
This PR gets rid of the unnecessary file by picking out the one definition that is actually needed.