Skip to content

Added cast blacklist for certain transform agg funcs #19355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jan 23, 2018

@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #19355 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19355      +/-   ##
==========================================
+ Coverage   91.54%   91.57%   +0.02%     
==========================================
  Files         150      150              
  Lines       48702    48705       +3     
==========================================
+ Hits        44585    44600      +15     
+ Misses       4117     4105      -12
Flag Coverage Δ
#multiple 89.94% <100%> (+0.02%) ⬆️
#single 41.72% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/groupby.py 92.15% <100%> (+0.01%) ⬆️
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9872d67...3f8b7f3. Read the comment docs.

@jreback jreback added Groupby Dtype Conversions Unexpected or buggy dtype conversions labels Jan 23, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 23, 2018
@jreback jreback merged commit 45aa0ce into pandas-dev:master Jan 23, 2018
@jreback
Copy link
Contributor

jreback commented Jan 23, 2018

thanks @WillAyd nice patch! keep em coming!

@WillAyd WillAyd deleted the trfn-dtype branch January 23, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform with Count Agg against DateTime returns DateTime
2 participants