LINT: Adding scripts directory to lint, and fixing flake issues on them (#18949) #19344
Conversation
|
Hello @datapythonista! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 23, 2018 at 11:46 Hours UTC |
scripts/merge-pr.py
Outdated
|
|
||
| Usage:: | ||
|
|
||
| $ ./apache-pr-merge.py (see config env vars below) |
There was a problem hiding this comment.
This must have been copied verbatim, since our file isn't called apache-pr-merge (just pr-merge).
scripts/api_rst_coverage.py
Outdated
| @@ -61,21 +63,25 @@ def add_notes(x): | |||
| # class members | |||
| class_members = set() | |||
| for cls in classes: | |||
| class_members.update([cls.__name__ + '.' + x[0] for x in inspect.getmembers(cls)]) | |||
| class_members.update('%s.%s' % (cls.__name__, x[0]) | |||
There was a problem hiding this comment.
We're moving away from this string formatting mechanism in favor of named kwargs.
| argparser.add_argument('--debug-level', | ||
| default="CRITICAL", | ||
| help='debug level of messages (DEBUG,INFO,etc...)') | ||
|
|
||
| help='debug level of messages (DEBUG,INFO,etc...)') |
There was a problem hiding this comment.
Add space between "," and "INFO"
|
@gfyoung, thanks for your comments, fixed them. I agree about documenting the scripts, but as you suggest I also think that should go in a separate PR. I think scripts like Also, I'm thinking in merging And there are others like the ones related to the release, that I'm surely not the best person to describe how to use them. :) |
| @@ -223,7 +222,7 @@ def update_pr(pr_num, user_login, base_ref): | |||
| try: | |||
| run_cmd( | |||
| 'git push -f %s %s:%s' % (push_user_remote, pr_branch_name, | |||
There was a problem hiding this comment.
separtely, would like to change format strings from % to .format()
|
thanks @datapythonista also if you can create an issue for #19344 (comment) comments and change |
git diff upstream/master -u -- "*.py" | flake8 --diff