Split test_ops_compat into targeted tests #19334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Testing
jreback
requested changes
Jan 21, 2018
|
|
||
| offsets = [pd.offsets.Hour(2), timedelta(hours=2), |
There was a problem hiding this comment.
should you parametrize over the offsets? (e.g. make them a fixture)?
There was a problem hiding this comment.
That’s what delta fixture is.
Codecov Report
@@ Coverage Diff @@
## master #19334 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 150 150
Lines 48700 48700
=======================================
Hits 44595 44595
Misses 4105 4105
Continue to review full report at Codecov.
|
jreback
approved these changes
Jan 22, 2018
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This and a couple other test-organizing PRs are being split off of a WIP branch to fix division-by-zero consistency.
git diff upstream/master -u -- "*.py" | flake8 --diff