BUG: DatetimeIndex(tz) & single column name, return empty df (GH19157) #19330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 21, 2018
| @@ -518,7 +518,17 @@ def _get_axes(N, K, index=index, columns=columns): | |||
| return _arrays_to_mgr([values], columns, index, columns, | |||
| dtype=dtype) | |||
| elif is_datetimetz(values): | |||
| return self._init_dict({0: values}, index, columns, dtype=dtype) | |||
There was a problem hiding this comment.
I think we we can just call _arrays_to_mgr here instead, w/o all of this additional code
jreback
added
Datetime
|
you can add tests for #13407 as well (if this fixes it). |
Codecov Report
@@ Coverage Diff @@
## master #19330 +/- ##
==========================================
- Coverage 91.65% 91.63% -0.03%
==========================================
Files 150 150
Lines 48724 48726 +2
==========================================
- Hits 44658 44648 -10
- Misses 4066 4078 +12
Continue to review full report at Codecov.
|
jreback
approved these changes
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThis issue is due to self._init_dict({0: values}, index, columns, dtype=dtype) will call for the filtering if columns passed (
data = {k: v for k, v in compat.iteritems(data) if k in columns}), see function_init_dictof frame.pySo
self._init_dict({0: values}, index, columns, dtype=dtype)expects the column name of values as '0', but since we pass a column with a different name, upon filtering it will result in an empty DataFrame.My solution assumes that the conversion of a series of DatetimeIndex with tz_info. Hence, we will initialize a DataFrame according to the given column name. If no column name specified, index '0' is chosen. I introduced an assertion to warn the users if multiple column names are passed.
Update 27-01-2018: The updated PR includes a test, and update on whatsnew entry. The revised solution uses
_arrays_to_mgrinstead, such that a default column name 0 is specified ifcolumnsnot specified.