Implement libinternals #19293
Implement libinternals #19293
Conversation
|
pls just do a move. do a followup to change things. when you move a file its impossible to tell diffs. |
jreback
added
Internals
|
OK, just changed to be pure cut/paste, will do optimizations in follow-up. |
|
|
||
|
|
||
| cdef class BlockPlacement: | ||
| # __slots__ = '_as_slice', '_as_array', '_len' |
There was a problem hiding this comment.
in followup is fine, pls add doc-strings
| return BlockPlacement(np.concatenate([self.as_array] + | ||
| [o.as_array for o in others])) | ||
|
|
||
| cdef iadd(self, other): |
There was a problem hiding this comment.
these should prob be typed
There was a problem hiding this comment.
Yep. Bunch of small things like this I'll do in the next pass. For now it's pure cut/paste.
|
shouldn't this be called internals and not libinternals? |
The filename is "internals.pyx". I've gotten used to the convention |
|
thanks! |
|
follow up for docs and small optimizations ok |
|
Huh? Was this meant to be closed or merged? |
|
it is merged see the hash above |
A bunch of functions from
libthat are only used in core.internals, have light dependencies.Small optimizations: made
slice_getitemacdefinstead ofdef, use PySlice_Check instead of isinstance.