-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Remove unused core.internals methods #19250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
62bbf21
remove unused itemsize; de-duplicate DatetimeTZBlock methods
jbrockmendel 495b522
remove unused reindex_axis methods
jbrockmendel 8d640a7
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel b229159
requested edits
jbrockmendel fb8c9ea
extra comment
jbrockmendel 6c4df2e
remove freq
jbrockmendel 274e9d4
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel 97a60dd
revert box_func de-duplication per request
jbrockmendel 2256b5d
revert duplicated get_values method
jbrockmendel d9d7829
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel 43d92de
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel 40bab35
Merge branch 'master' of https://github.com/pandas-dev/pandas into un…
jbrockmendel d8f1104
revert to use redundant get_values method
jbrockmendel 59b3e60
revert whitespace change
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of these may not be hit, I think I prefer the more idiomatic
new = getattr(new, 'values', new)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I'll check to see whether any value-less cases get through while I'm at it.