-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: assign doesnt cast SparseDataFrame to DataFrame #19178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6a10fa8
BUG: assign doesnt cast SparseDataFrame to DataFrame
hexgnu 686ef8e
BUG: Fixes problem with SparseArray coercing to float if index is passed
hexgnu d874c7f
Merge remote-tracking branch 'upstream/master' into sparse_assign
hexgnu ac6213a
Cleanup
hexgnu 3042568
More cleanup
hexgnu d900e11
More cleanup
hexgnu a17a593
Comments from PR Updates
hexgnu 925186d
Merge remote-tracking branch 'upstream/master' into sparse_assign
hexgnu 559434a
Fix linting error
hexgnu 16a272d
Update whatsnew entry and use cast function
hexgnu e35bc17
Merge remote-tracking branch 'upstream/master' into sparse_assign
hexgnu 2374bc6
Merge branch 'master' into PR_TOOL_MERGE_PR_19178
jreback a81796a
clean
jreback File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ | |
is_scalar, is_dtype_equal) | ||
from pandas.core.dtypes.cast import ( | ||
maybe_convert_platform, maybe_promote, | ||
astype_nansafe, find_common_type) | ||
astype_nansafe, find_common_type, infer_dtype_from_scalar) | ||
from pandas.core.dtypes.missing import isna, notna, na_value_for_dtype | ||
|
||
import pandas._libs.sparse as splib | ||
|
@@ -161,7 +161,8 @@ def __new__(cls, data, sparse_index=None, index=None, kind='integer', | |
data = np.nan | ||
if not is_scalar(data): | ||
raise Exception("must only pass scalars with an index ") | ||
values = np.empty(len(index), dtype='float64') | ||
values = np.empty(len(index), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we have a routine for this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for the empty/fill step |
||
dtype=infer_dtype_from_scalar(data)[0]) | ||
values.fill(data) | ||
data = values | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, just noticed we don't have
SparseArray
in our API docs so this link won't work. Justuntil we get that sorted out. Also double ticks around data nd index.