DOC: Add documentation regarding no compression in to_parquet #19131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylogx
force-pushed
the
feature/doc/parquet_doc
branch
from
c618df8 to
1f6bc74
Compare
pandas/core/frame.py
Outdated
| @@ -1671,7 +1671,8 @@ def to_parquet(self, fname, engine='auto', compression='snappy', | |||
| 'io.parquet.engine' is used. If 'auto', then the first | |||
| library to be installed is used. | |||
| compression : str, optional, default 'snappy' | |||
| compression method, includes {'gzip', 'snappy', 'brotli'} | |||
| Available compression methods are {'gzip', 'snappy', 'brotli'} | |||
There was a problem hiding this comment.
Could you reformat this as
compression : {'snappy', 'gzip', 'brotli', None}
Name of the compression to use. Use ``None`` for no compression
So that it follows https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt (section 4)
Same for down below.
ylogx
force-pushed
the
feature/doc/parquet_doc
branch
from
1f6bc74 to
5b65ed8
Compare
|
@TomAugspurger 👍 Done. |
TomAugspurger
approved these changes
Jan 8, 2018
Codecov Report
@@ Coverage Diff @@
## master #19131 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 148 148
Lines 48780 48780
=======================================
Hits 44651 44651
Misses 4129 4129
Continue to review full report at Codecov.
|
|
Thanks @ylogx. Was there an issue for this? |
|
@TomAugspurger Nope, I felt that this change could be discussed over the PR itself. |
maximveksler
pushed a commit
to maximveksler/pandas
that referenced
this pull request
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.