Skip to content

Parametrized test_json_table_schema module #19128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jan 8, 2018

Could potentially consolidate all of the dtype tests further but didn't want to rock the boat too much

@codecov
Copy link

codecov bot commented Jan 8, 2018

Codecov Report

Merging #19128 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19128      +/-   ##
==========================================
- Coverage   91.53%   91.51%   -0.03%     
==========================================
  Files         148      148              
  Lines       48780    48780              
==========================================
- Hits        44651    44639      -12     
- Misses       4129     4141      +12
Flag Coverage Δ
#multiple 89.88% <ø> (-0.03%) ⬇️
#single 41.61% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c0f8a...16d0262. Read the comment docs.

@TomAugspurger TomAugspurger merged commit 5205283 into pandas-dev:master Jan 8, 2018
@TomAugspurger
Copy link
Contributor

Thanks!

@TomAugspurger TomAugspurger added this to the 0.23.0 milestone Jan 8, 2018
@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite Refactor Internal refactoring of code labels Jan 8, 2018
maximveksler pushed a commit to maximveksler/pandas that referenced this pull request Jan 11, 2018
@WillAyd WillAyd deleted the json-parametrize branch February 27, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametrize pandas to JSON field tests in test_json_table_schema
2 participants