Skip to content

TST: Add test for setting with loc on DataFrame with one row #19127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

jschendel
Copy link
Member

@jschendel jschendel commented Jan 8, 2018

Issue appears to be have been fixed for a while, since 0.21.x at least, just added a test to ensure there's no regression.

@jschendel jschendel changed the title TST: Add test for setting with on loc DataFrame with one row TST: Add test for setting with loc on DataFrame with one row Jan 8, 2018
@codecov
Copy link

codecov bot commented Jan 8, 2018

Codecov Report

Merging #19127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19127   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         148      148           
  Lines       48780    48780           
=======================================
  Hits        44639    44639           
  Misses       4141     4141
Flag Coverage Δ
#multiple 89.88% <ø> (ø) ⬆️
#single 41.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5194e5...f3a2bbf. Read the comment docs.

@jreback jreback added Bug Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves Dtype Conversions Unexpected or buggy dtype conversions labels Jan 9, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 9, 2018
@jreback
Copy link
Contributor

jreback commented Jan 9, 2018

thanks. will merge after fixing travis :<

@jreback jreback merged commit 928affd into pandas-dev:master Jan 10, 2018
@jreback
Copy link
Contributor

jreback commented Jan 10, 2018

thanks @jschendel

maximveksler pushed a commit to maximveksler/pandas that referenced this pull request Jan 11, 2018
@jschendel jschendel deleted the loc-single-row branch January 15, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: dt.strftime causes TypeError when there is only one row in DataFrame
2 participants