BUG: Fixed union_categoricals with unordered cats #19097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 5, 2018
| c1 = Categorical(['a', 'b', 'c'], categories=['a', 'b', 'c']) | ||
| c2 = Categorical(['a', 'b', 'c'], categories=['b', 'a', 'c']) | ||
| result = union_categoricals([c1, c2]) | ||
| expected = Categorical(['a', 'b', 'c', 'a', 'b', 'c'], |
There was a problem hiding this comment.
maybe add the concat example too?
Codecov Report
@@ Coverage Diff @@
## master #19097 +/- ##
==========================================
+ Coverage 91.51% 91.54% +0.02%
==========================================
Files 148 148
Lines 48754 48757 +3
==========================================
+ Hits 44619 44634 +15
+ Misses 4135 4123 -12
Continue to review full report at Codecov.
|
|
lgtm. ping on green. |
jreback
approved these changes
Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19096