CLN: ASV string #19069
Merged
CLN: ASV string #19069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mroeschke! Thanks for updating the PR.
Comment last updated on January 06, 2018 at 05:42 Hours UTC |
mroeschke
force-pushed
the
asv_clean_string
branch
from
1462adc to
897f60b
Compare
Codecov Report
@@ Coverage Diff @@
## master #19069 +/- ##
==========================================
+ Coverage 91.51% 91.53% +0.01%
==========================================
Files 148 148
Lines 48680 48688 +8
==========================================
+ Hits 44550 44566 +16
+ Misses 4130 4122 -8
Continue to review full report at Codecov.
|
jreback
requested changes
Jan 5, 2018
| from pandas import WidePanel as Panel # noqa | ||
|
|
||
| # Compatibility import for lib | ||
| for imp in ['pandas._libs.lib', 'pandas.lib', 'pandas_tseries']: |
There was a problem hiding this comment.
this last is wrong pandas_tseries, where did this come from?
There was a problem hiding this comment.
Not sure; pandas_tseries was present here when I started the clean-up. I can remove this
There was a problem hiding this comment.
ok let's do, otherwise lgtm.
|
There is no open issue about linting the asv (#18545 is a closed issue about linting them). |
|
Removed |
jreback
approved these changes
Jan 6, 2018
|
thanks @mroeschke nice work! can you give a run to all benchmarks to make sure that they run and nothing is too excessive for times. |
|
I still have 3 more timeseries benchmarks left to clean up, but it looks like there's some benchmarks in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the
strings.pybenchmarks,pandas_vb_common.pyof all the unnecessary imports, and linting all the.pyfiles inasv_benchnow.