-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: incorrect set_labels in MI #19058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ee3204c
Fix #19057
Mofef caf1a65
Test set_labels for distinctly sized index levels
Mofef 3c79f35
Add whatsnew entry
Mofef 2ad4fa9
Simplify added test code
Mofef 14fd575
Merge branch 'master' into patch-1
TomAugspurger 48fb843
CI: Trigger CI with empty commit
TomAugspurger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -327,6 +327,28 @@ def assert_matching(actual, expected): | |
assert_matching(ind2.labels, new_labels) | ||
assert_matching(self.index.labels, labels) | ||
|
||
def test_set_label_distinctly_sized_levels(self): | ||
# label changing for levels of different magnitude of categories | ||
def assert_equal(actual, expected): | ||
assert len(actual) == len(expected) | ||
for act, exp in zip(actual, expected): | ||
act = np.asarray(act) | ||
exp = np.asarray(exp) | ||
tm.assert_numpy_array_equal(act, exp, check_dtype=True) | ||
|
||
ind = pd.MultiIndex.from_tuples([(0, i) for i in range(130)]) | ||
new_labels = range(129, -1, -1) | ||
ind_reference = pd.MultiIndex.from_tuples( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. call this expected |
||
[(0, i) for i in new_labels]) | ||
|
||
# [w/o mutation] | ||
ind2 = ind.set_labels(labels=new_labels, level=1) | ||
assert_equal(ind2, ind_reference) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. call these result, then you can simply do
for the inplace case you need to copy before |
||
|
||
# [w/ mutation] | ||
ind.set_labels(labels=new_labels, level=1, inplace=True) | ||
assert_equal(ind, ind_reference) | ||
|
||
def test_set_levels_labels_names_bad_input(self): | ||
levels, labels = self.index.levels, self.index.labels | ||
names = self.index.names | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see below this is not necessary