CLN: ASV stat_ops #19049
Merged
CLN: ASV stat_ops #19049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mroeschke! Thanks for updating the PR.
Comment last updated on January 06, 2018 at 05:37 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #19049 +/- ##
==========================================
+ Coverage 91.51% 91.53% +0.01%
==========================================
Files 148 148
Lines 48807 48688 -119
==========================================
- Hits 44667 44566 -101
+ Misses 4140 4122 -18
Continue to review full report at Codecov.
|
jreback
reviewed
Jan 3, 2018
asv_bench/benchmarks/rolling.py
Outdated
| class DepreciatedRolling(object): | ||
|
|
||
| sample_time = 0.2 | ||
| params = ['rolling_median', 'rolling_mean', 'rolling_min', 'rolling_max', |
There was a problem hiding this comment.
i would prob remove these, we go back pretty far with the newer stuff already.
jreback
reviewed
Jan 3, 2018
asv_bench/benchmarks/stat_ops.py
Outdated
| param_names = ['op', 'use_bottleneck', 'dtype', 'axis'] | ||
| params = [['mean', 'sum', 'median'], | ||
| params = [['mean', 'sum', 'median', 'std'], |
There was a problem hiding this comment.
you could make use_bottleneck a param here
There was a problem hiding this comment.
use_bottleneck is a param here, over [True, False]
jreback
added
Benchmark
mroeschke
force-pushed
the
asv_clean_stats_ops
branch
from
c9ec227 to
5fd9420
Compare
|
Removed the older rolling benchmarks. |
jreback
requested changes
Jan 4, 2018
asv_bench/benchmarks/stat_ops.py
Outdated
|
|
||
| class stats_rank2d_axis1_average(object): | ||
| goal_time = 0.2 | ||
| def setup(self, op, use_bottleneck, dtype): |
There was a problem hiding this comment.
you could put the bottleneck tests in a separate function / base class I think
|
Created a new class for the bottleneck benchmarks: |
jreback
approved these changes
Jan 5, 2018
jreback
requested changes
Jan 5, 2018
asv_bench/benchmarks/stat_ops.py
Outdated
| goal_time = 0.2 | ||
| param_names = ['op', 'dtype'] |
There was a problem hiding this comment.
what I meant about bottleneck was make it a parameter in ops, e.g. here
asv_bench/benchmarks/stat_ops.py
Outdated
| goal_time = 0.2 | ||
| param_names = ['op', 'dtype', 'axis'] | ||
| params = [['mean', 'sum', 'median', 'std'], |
There was a problem hiding this comment.
and use bottleneck here, also expand these to all of the stat ops (min, max, var, kurt, etc)
|
Defined a list of ops at the top of the file that each benchmark |
jreback
approved these changes
Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some old
pd.rolling_*methods being tested instat_ops.pythat I moved torolling.py(or should they just be removed?), otherwise the usual cleanup: