TST: Split tests/indexes/interval/test_interval.py into separate files #19009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Interval
jreback
reviewed
Dec 30, 2017
| return request.param | ||
|
|
||
|
|
||
| class TestIntervalRange(object): |
There was a problem hiding this comment.
as an aside, we don't generally need classes, unless you have multiple logical groupings within a single file (but then usually we just want separate files). no harm though.
|
lgtm. ping on travis green. |
|
thanks @jschendel |
hexgnu
pushed a commit
to hexgnu/pandas
that referenced
this pull request
Jan 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffSince we now have an interval subdirectory, seems logical to split
test_interval.pyinto separate files, similar to what has been done forDatetimeIndex,PeriodIndex, andTimedeltaIndex.Just made very basic changes here, moving things at the class level, and didn't break apart any classes. All of the tests should functionally be the same.
Summary:
TestIntervalRangeclass fromtest_interval.pytotest_interval_range.pyTestIntervalTreeclass fromtest_interval.pytotest_interval_tree.pyforloops to@pytest.mark.parametrizelambdato an actual function (my linter was complaining about PEP8 E731)test_interval_new.pytest_interval.pyDown the road we could probably split
test_interval.pyinto smaller components, much like what was done forDatetimeIndex,PeriodIndex, andTimedeltaIndex. Might want to wait until the_new.pyfiles are fully addressed though. Didn't look like there were any high level changes like this that could be made intests/indexing/interval/.