-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Misc. Typo fixes #18966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. Typo fixes #18966
Conversation
thanks @luzpaz have a look at https://travis-ci.org/pandas-dev/pandas/jobs/322503804 couple of linting issues (now lines too long) as well as a failing test that checks the error message (you can adjust the test / message). |
@jreback apologies, i'm having trouble understanding the errors of the tests on TravisCI. Are all of those issues related to this PR ? Can you give me an example of lines that are too long? I'll be happy to fix, I'm not yet down with the lingo. Thank you. |
will show the linting issues |
also you need to merge master. and there is 1 test failure as indicated. |
Both user and non-user facing. Found via `codespell -q 3 -I ../pandas-whitelist.txt` whereby the whitelist consisted of: ``` behaviour indicies initialise initialised initialising resetted thru writeable ```
@jreback After I rebase, should I force push or just create another commit ? |
you can force push if you rebase, or simply |
2nd is prob easier |
0d51bed
to
3cdc483
Compare
thanks @luzpaz nice patch! |
Codecov Report
@@ Coverage Diff @@
## master #18966 +/- ##
==========================================
- Coverage 91.57% 91.55% -0.03%
==========================================
Files 150 150
Lines 48933 48933
==========================================
- Hits 44812 44800 -12
- Misses 4121 4133 +12
Continue to review full report at Codecov.
|
Both user and non-user facing. Found via
codespell -q 3 -I ../pandas-whitelist.txt
whereby the whitelist consisted of: