Skip to content

Misc. Typo fixes #18966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 30, 2017
Merged

Misc. Typo fixes #18966

merged 6 commits into from
Dec 30, 2017

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Dec 28, 2017

Both user and non-user facing. Found via codespell -q 3 -I ../pandas-whitelist.txt whereby the whitelist consisted of:

behaviour
indicies
initialise
initialised
initialising
resetted
thru
writeable

@jreback
Copy link
Contributor

jreback commented Dec 28, 2017

thanks @luzpaz

have a look at https://travis-ci.org/pandas-dev/pandas/jobs/322503804

couple of linting issues (now lines too long) as well as a failing test that checks the error message (you can adjust the test / message).

@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 29, 2017

@jreback apologies, i'm having trouble understanding the errors of the tests on TravisCI. Are all of those issues related to this PR ? Can you give me an example of lines that are too long? I'll be happy to fix, I'm not yet down with the lingo. Thank you.

@jreback
Copy link
Contributor

jreback commented Dec 29, 2017

git diff master --name-only -- "*.py" | grep "pandas" | xargs flake8

will show the linting issues

@jreback
Copy link
Contributor

jreback commented Dec 29, 2017

also you need to merge master. and there is 1 test failure as indicated.

Both user and non-user facing. Found via `codespell -q 3  -I ../pandas-whitelist.txt` whereby the whitelist consisted of: 
```
behaviour
indicies
initialise
initialised
initialising
resetted
thru
writeable
```
@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 30, 2017

@jreback After I rebase, should I force push or just create another commit ?

@jreback
Copy link
Contributor

jreback commented Dec 30, 2017

you can force push if you rebase, or simply git merge master and just keep pushing commits.

@jreback
Copy link
Contributor

jreback commented Dec 30, 2017

2nd is prob easier

@jreback jreback added this to the 0.23.0 milestone Dec 30, 2017
@jreback jreback merged commit ad043d1 into pandas-dev:master Dec 30, 2017
@jreback
Copy link
Contributor

jreback commented Dec 30, 2017

thanks @luzpaz nice patch!

@codecov
Copy link

codecov bot commented Dec 30, 2017

Codecov Report

Merging #18966 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18966      +/-   ##
==========================================
- Coverage   91.57%   91.55%   -0.03%     
==========================================
  Files         150      150              
  Lines       48933    48933              
==========================================
- Hits        44812    44800      -12     
- Misses       4121     4133      +12
Flag Coverage Δ
#multiple 89.91% <100%> (-0.03%) ⬇️
#single 41.75% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/melt.py 97.24% <ø> (ø) ⬆️
pandas/core/sparse/array.py 91.82% <ø> (ø) ⬆️
pandas/io/formats/excel.py 96.71% <ø> (ø) ⬆️
pandas/core/dtypes/cast.py 88.42% <ø> (ø) ⬆️
pandas/core/computation/pytables.py 92.37% <ø> (ø) ⬆️
pandas/core/algorithms.py 94.14% <ø> (ø) ⬆️
pandas/tseries/holiday.py 93.1% <ø> (ø) ⬆️
pandas/core/indexes/interval.py 92.61% <ø> (ø) ⬆️
pandas/core/indexing.py 92.81% <ø> (ø) ⬆️
pandas/io/formats/console.py 69.69% <ø> (ø) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e8ee2...414ee94. Read the comment docs.

@luzpaz luzpaz deleted the pandas-misc-typos branch December 30, 2017 17:11
@jreback jreback mentioned this pull request Dec 31, 2017
hexgnu pushed a commit to hexgnu/pandas that referenced this pull request Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants